cdfmlr commented on PR #1983: URL: https://github.com/apache/libcloud/pull/1983#issuecomment-2175904320
@Kami sorry for my delay. I have added [more tests](https://github.com/apache/libcloud/pull/1983/commits/f765b4299de9770ac49e9f5343ee28a96d99e26b) covering the helper functions (`_deep_merge_dict` and `_memory_in_MB`) and some typical unhappy code paths. The `_create_node()` method has been [refactored](https://github.com/apache/libcloud/pull/1983/commits/40ec5efd603a75ecb315ea5edd562e4e19baa1cb) into smaller functions as well. Meanwhile, a useful new feature to [set cpu/mem requests and limits separately](https://github.com/apache/libcloud/pull/1983/commits/4c622eef1236032b3548470f310ae0e9b6ac2d8c) is introduced and [tested](https://github.com/apache/libcloud/pull/1983/commits/f78d36141939e1e5fe35a94366d4f98143ee5b31). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
