[
https://issues.apache.org/jira/browse/LOG4J2-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414542#comment-16414542
]
Matt Sicker commented on LOG4J2-1705:
-------------------------------------
Hey, sorry for not getting back sooner. Anyways, I have some more feedback and
questions.
* I'd suggest having integration tests using a {{ListAppender}}. That's a
common pattern throughout Log4j, and I see you already usedÂ
{{LoggerContextRule}} elsewhere.
* Yes, you can go ahead and delete {{KotlinCompleteLogger}}.
* The nullable type in the generic thing is something I missed and is pretty
neat!
* We can fix the FQCN API issue by excluding those particular methods from the
public API for now and fixing it with a later Log4j release.
As for some bookkeeping tasks to get this integrated as an official subproject:
* The API artifact id should be {{log4j-api-kotlin}} to match the existing
naming scheme.
* The group id should be changed to {{org.apache.logging.log4j}} as well.
* We'll be using the pre-made repo
[here|https://github.com/apache/logging-log4j-kotlin] to merge into.
* Being a Kotlin project, would it make more sense to use gitbox (GitHub)
instead of the traditional git.apache.org+Jira workflow? I think that would
help reduce friction in community contributions.
> Kotlin wrapper for Log4j 2 API
> ------------------------------
>
> Key: LOG4J2-1705
> URL: https://issues.apache.org/jira/browse/LOG4J2-1705
> Project: Log4j 2
> Issue Type: New Feature
> Components: API
> Reporter: Raman Gupta
> Priority: Major
>
> Similar to LOG4J2-1181 for Scala, provide a Kotlin wrapper for the Log4j 2
> API that makes use of Kotlin features like delegates and string interpolation.
> If there is interest in this, I'd like to contribute a patch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
