[
https://issues.apache.org/jira/browse/LOG4J2-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416190#comment-16416190
]
Raman Gupta commented on LOG4J2-1705:
-------------------------------------
[~jvz] thanks, not sure if you noticed but the last few commits did include the
updates you requested... see below for comments:
> I'd suggest having integration tests using a {{ListAppender}}.
Ok, done, check out LoggerCompanionTest, LoggerMixinCompanionExtendsTest, and
LoggerMixinExtendsTest. I've also filled out the LoggerTest a little bit.
> Yes, you can go ahead and delete {{KotlinCompleteLogger}}.
Done!
> The nullable type in the generic thing is something I missed and is pretty
>neat!
It is, isn't it? It's stuff like this that makes me realize Kotlin is *really*
well thought out.
> The API artifact id should be {{log4j-api-kotlin}} to match the existing
>naming scheme.
-It is already isn't it? The parent is log4j-kotlin, but the API artifact is
log4j-api-kotlin. The group id is already org.apache.logging.log4j also.- Never
mind, I see the changes you made on the (now) upstream repo.
> Being a Kotlin project, would it make more sense to use gitbox (GitHub)
>instead of the traditional git.apache.org+Jira workflow?
This works for me.
> Kotlin wrapper for Log4j 2 API
> ------------------------------
>
> Key: LOG4J2-1705
> URL: https://issues.apache.org/jira/browse/LOG4J2-1705
> Project: Log4j 2
> Issue Type: New Feature
> Components: API
> Reporter: Raman Gupta
> Assignee: Matt Sicker
> Priority: Major
>
> Similar to LOG4J2-1181 for Scala, provide a Kotlin wrapper for the Log4j 2
> API that makes use of Kotlin features like delegates and string interpolation.
> If there is interest in this, I'd like to contribute a patch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
