[
https://issues.apache.org/jira/browse/LOG4J2-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461088#comment-16461088
]
ASF GitHub Bot commented on LOG4J2-2331:
----------------------------------------
GitHub user mikebski opened a pull request:
https://github.com/apache/logging-log4j2/pull/172
Fix for https://issues.apache.org/jira/browse/LOG4J2-2331
Fix for https://issues.apache.org/jira/browse/LOG4J2-2331 - use logger
string formatting instead of concatenation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mikebski/logging-log4j2 master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #172
----
commit 534cf03241314a67a6a9bc11b45e923b0bb76d43
Author: Mike Baranski <baranski@...>
Date: 2018-05-02T14:20:30Z
Fix for https://issues.apache.org/jira/browse/LOG4J2-2331 - use logger
string formatting instead of concatenation
----
> Rolling file appender concatenating debug message instead of using formatting
> -----------------------------------------------------------------------------
>
> Key: LOG4J2-2331
> URL: https://issues.apache.org/jira/browse/LOG4J2-2331
> Project: Log4j 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.11.0
> Environment: Any - Mac with log4j 2.11.0 using `-Dlog4j.debug` and a
> RollingFileAppender
> Reporter: Michael Wells Baranski
> Priority: Minor
> Labels: easyfix
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When debug is on, RollingFileAppender prints the shutdown message and
> concatenates the name, instead of passing it as an argument to be formatted:
> `"Shutting down RollingFileManager {}" + getName()`
> should be:
> `"Shutting down RollingFileManager {}", getName()`
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
