[ 
https://issues.apache.org/jira/browse/LOG4J2-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461140#comment-16461140
 ] 

ASF subversion and git services commented on LOG4J2-2331:
---------------------------------------------------------

Commit ede615ce054d71ba3c2c252b416dada441ed42ea in logging-log4j2's branch 
refs/heads/release-2.x from [~mbaranski]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=ede615c ]

[LOG4J2-2331] use logger string formatting instead of concatenation

RollingFileManager debug logging avoids string concatenation and
errant braces in favor of parameterized logging.


> Rolling file appender concatenating debug message instead of using formatting
> -----------------------------------------------------------------------------
>
>                 Key: LOG4J2-2331
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2331
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.11.0
>         Environment: Any - Mac with log4j 2.11.0 using `-Dlog4j.debug` and a 
> RollingFileAppender
>            Reporter: Michael Wells Baranski
>            Assignee: Carter Kozak
>            Priority: Minor
>              Labels: easyfix
>             Fix For: 3.0.0, 2.11.1
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When debug is on, RollingFileAppender prints the shutdown message and 
> concatenates the name, instead of passing it as an argument to be formatted:
> `"Shutting down RollingFileManager {}" + getName()`
> should be:
> `"Shutting down RollingFileManager {}", getName()`



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to