carterkozak commented on a change in pull request #329: ThrowableProxy
pre-warms its cache using the detected stack
URL: https://github.com/apache/logging-log4j2/pull/329#discussion_r362289863
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxyHelper.java
##########
@@ -96,34 +99,46 @@ private CacheEntry(final ExtendedClassInfo element, final
ClassLoader loader) {
// and its implementation. The Throwable might also contain stack
entries that are no longer
// present as those methods have returned.
Review comment:
This comment should move to `createCacheFromStack`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
