carterkozak commented on a change in pull request #329: ThrowableProxy
pre-warms its cache using the detected stack
URL: https://github.com/apache/logging-log4j2/pull/329#discussion_r362290037
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java
##########
@@ -104,8 +104,8 @@ public ThrowableProxy(final Throwable throwable) {
this.name = throwable.getClass().getName();
this.message = throwable.getMessage();
this.localizedMessage = throwable.getLocalizedMessage();
- final Map<String, ThrowableProxyHelper.CacheEntry> map = new
HashMap<>();
final Stack<Class<?>> stack = StackLocatorUtil.getCurrentStackTrace();
Review comment:
Note (unrelated to this commit): This doesn't quite work when we use the
AsyncLoggerContextSelector because ThrowableProxy instances are created lazily
on the background thread, where the current stack isn't helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
