turbanoff commented on issue #338: use 'final' modifier for fields where possible URL: https://github.com/apache/logging-log4j2/pull/338#issuecomment-581656719 I didn't touch fields in samples, tests and perf modules. Field `org.apache.logging.log4j.core.layout.AbstractStringLayout#charset` looks strange. Looks like it should be initialized in `readObject` method, but it was removed here - https://github.com/apache/logging-log4j2/commit/afd417ce965fd6100134ac775aef1be98a927250 See https://github.com/apache/logging-log4j2/commit/afd417ce965fd6100134ac775aef1be98a927250#diff-1c90b17f7481c4e5ae5a134261a36209
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
