turbanoff commented on a change in pull request #338: use 'final' modifier for
fields where possible
URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376771316
##########
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java
##########
@@ -29,8 +29,8 @@
static final long serialVersionUID = -4748765566864322735L;
- private transient Throwable throwable;
- private Method toStringList;
+ private final transient Throwable throwable;
Review comment:
>It is quite possible that the objects can be recreated during
deserialization from the data that is present.
But there is no such code. It means they are not recreated. I someone in
future will deserialization code - he can also remove `final` modifier.
Moreover if classes `FormattedMessage`, `StringFormattedMessage` and
`ParameterizedMessage`: code is already ready to have this fields `final` and
`null`. Such fields are not serialized and not read from ObjectOutputStream.
If you insist - I will remove final
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
