turbanoff commented on a change in pull request #338: use 'final' modifier for
fields where possible
URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376814654
##########
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java
##########
@@ -29,8 +29,8 @@
static final long serialVersionUID = -4748765566864322735L;
- private transient Throwable throwable;
- private Method toStringList;
+ private final transient Throwable throwable;
Review comment:
Just couple examples to show, that having `final transient` it's ok:
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/time/ZoneRegion.java#L104
https://github.com/OpenGamma/Strata/blob/master/modules/collect/src/main/java/com/opengamma/strata/collect/array/DoubleMatrix.java#L66
https://github.com/google/guava/blob/master/guava/src/com/google/common/reflect/TypeToken.java#L701
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
