aallrd commented on a change in pull request #22: Only exporting the log4cxx
symbols by default
URL: https://github.com/apache/logging-log4cxx/pull/22#discussion_r406709783
##########
File path: src/site/apt/building/cmake.apt
##########
@@ -39,24 +39,26 @@ $ sudo make install
* ccmake options
-*------------------------+---------------------------------------------------------------------------------------------+
-| -DLOG4CXX_WCHAR_T=no | Enable wchar_t API methods, choice of yes
(default), no. |
-*------------------------+---------------------------------------------------------------------------------------------+
-| -DLOG4CXX_UNICHAR=yes | Enable UniChar API methods, choice of yes, no
(default). |
-*------------------------+---------------------------------------------------------------------------------------------+
-| -DLOG4CXX_CFSTRING=yes | Enable CFString API methods, requires Mac OS/X
CoreFoundation, choice of yes, no (default). |
-*------------------------+---------------------------------------------------------------------------------------------+
-| -DBUILD_TESTING=off | Do not build tests. Tests are built by default
|
-*------------------------+---------------------------------------------------------------------------------------------+
-| -DBUILD_SHARED_LIBS=off| Build log4cxx as a static library. A dynamically
linked log4cxx library is built by default.|
-| | Any compilation unit that includes a log4cxx header
must define LOG4CXX_STATIC. |
-*------------------------+---------------------------------------------------------------------------------------------+
-| -DAPU_STATIC=yes | Link to the APR-Util static library. By default,
the log4cxx shared library is linked to the|
-| | APR-Util shared library. If BUILD_SHARED_LIBS=off,
the static APR-Util library is used. |
-*------------------------+---------------------------------------------------------------------------------------------+
-| -DAPR_STATIC=yes | Link to the APR static library. By default, the
log4cxx shared library is linked to the |
-| | APR shared library. If BUILD_SHARED_LIBS=off, the
static APR library is always used. |
-*------------------------+---------------------------------------------------------------------------------------------+
+*-----------------------------------+---------------------------------------------------------------------------------------------+
+| -DLOG4CXX_WCHAR_T=no | Enable wchar_t API methods, choice of
yes (default), no. |
+*-----------------------------------+---------------------------------------------------------------------------------------------+
+| -DLOG4CXX_UNICHAR=yes | Enable UniChar API methods, choice of
yes, no (default). |
+*-----------------------------------+---------------------------------------------------------------------------------------------+
+| -DLOG4CXX_CFSTRING=yes | Enable CFString API methods, requires
Mac OS/X CoreFoundation, choice of yes, no (default). |
+*-----------------------------------+---------------------------------------------------------------------------------------------+
+| -DBUILD_TESTING=off | Do not build tests. Tests are built by
default |
+*-----------------------------------+---------------------------------------------------------------------------------------------+
+| -DBUILD_SHARED_LIBS=off | Build log4cxx as a static library. A
dynamically linked log4cxx library is built by default.|
+| | Any compilation unit that includes a
log4cxx header must define LOG4CXX_STATIC. |
+*-----------------------------------+---------------------------------------------------------------------------------------------+
+| -DAPU_STATIC=yes | Link to the APR-Util static library. By
default, the log4cxx shared library is linked to the|
+| | APR-Util shared library. If
BUILD_SHARED_LIBS=off, the static APR-Util library is used. |
+*-----------------------------------+---------------------------------------------------------------------------------------------+
+| -DAPR_STATIC=yes | Link to the APR static library. By
default, the log4cxx shared library is linked to the |
+| | APR shared library. If
BUILD_SHARED_LIBS=off, the static APR library is always used. |
+*-----------------------------------+---------------------------------------------------------------------------------------------+
+| -DEXPORT_ONLY_LOG4CXX_SYMBOLS=yes | Only export the log4cxx symbols in the
log4cxx shared library. |
Review comment:
Updated the documentation to show the default (no).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
