ams-tschoening edited a comment on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-612593743 @aallrd > Sorry for the incomplete PR, I wanted really to open an issue but I could not find how to to that on this project. Issues are maintained in the [Apache JIRA](https://issues.apache.org/jira/projects/LOGCXX/issues/) by default. so either create one there first next time or simply be a bit more verbose in the initial PR already. Doesn't make too much difference in my opinion. > Looking at a profiler report, I noticed that some standard functions and templates (like strings or others) were actually relocated at runtime to the log4cxx shared library (using LD_DEBUG=bindings LD_DEBUG_OUTPUT=ld.log ldd -r app). Do you know which functions and templates and why exactly that happens? I wonder if that is expected at all already and should be fixed instead of working around it using the symbols? > I think the same behavior can be achieved on Windows with Visual Studio using the linker /DEF option. Just as some docs, because I'm using C++-Builder, the following should be the corresponding options for that? * http://docwiki.embarcadero.com/RADStudio/Rio/en/Module_Definition_Files * http://docwiki.embarcadero.com/RADStudio/Rio/en/IMPDEF.EXE,_the_Module_Definition_Manager * http://docwiki.embarcadero.com/RADStudio/Rio/en/MKEXP.EXE,_the_64-bit_Windows_Import_Library_Tool_for_C%2B%2B * http://docwiki.embarcadero.com/RADStudio/Rio/en/C%2B%2B_Linker_Output @rm5248 > In that case, there's probably an easier way to do this.[...] I'm just trying to understand things, so: Why do you consider your approach easier? Having a well documented cmake-option doesn't seem that wrong to me. Your approach only implements non-Windows-compilers, doesn't it? Might the problem arise that this PR needs to be modified for Windows-compilers as well at some point? In the latter case it might be easier to add that to CMAKE only with different compiler-options and/or `.map|.def`-files?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
