aallrd commented on issue #22: Only exporting the log4cxx symbols by default URL: https://github.com/apache/logging-log4cxx/pull/22#issuecomment-613895179 Hello, Thank you for your comments, and for the interesting [GCC bugzilla report](https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36022). @rm5248, you are right that setting the visibility using these macros should be the best thing to do, as documented in the [GCC Visibility](https://gcc.gnu.org/wiki/Visibility) page. It makes the code itself cross-platforms and enables better compiler optimization. Regarding the linker version script, after reading even more on the subject I found that it can be indeed dangerous in some situations and that some std symbols are exported on purpose in order to allow throw-catch/dynamic_cast to work across shared libs boundaries. In the end I am not sure what to do anymore, and I am not convinced that this change is a good one. Since I don't fully understand either what is going on, I would like to avoid breaking things for you :). I will keep this patch on my internal project for the moment, try to implement the visibility macros for GCC in the project and test if they help solve my initial issue as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
