ams-tschoening commented on a change in pull request #30:
URL: https://github.com/apache/logging-log4cxx/pull/30#discussion_r457169943
##########
File path: INSTALL
##########
@@ -15,24 +15,16 @@ limitations under the License.
Detailed build instructions are provided for in both HTML
and APT format in releases. The APT sources are
-available in Subversion checkouts.
+available in Git checkouts.
autotools:
site/building/autotools.html
src/site/apt/building/autotools.apt
-Apache Ant:
-site/building/ant.html
-src/site/apt/building/ant.apt
+CMake:
Review comment:
How about using alphabetical order in this file? I've changed it at [the
corresponding
place](https://github.com/apache/logging-log4cxx/commit/96ef6546993a04e954bee4db4f0791a8138f3e00)
as well.
##########
File path: INSTALL
##########
@@ -15,24 +15,16 @@ limitations under the License.
Detailed build instructions are provided for in both HTML
and APT format in releases. The APT sources are
-available in Subversion checkouts.
+available in Git checkouts.
autotools:
site/building/autotools.html
src/site/apt/building/autotools.apt
-Apache Ant:
-site/building/ant.html
-src/site/apt/building/ant.apt
+CMake:
+site/building/cmake.html
+src/site/apt/building/cmake.apt
Apache Maven 2:
site/building/maven.html
src/site/apt/building/maven.apt
-
-Microsoft Visual Studio:
Review comment:
How about changing that to vcpkg? You did that [at other
places](https://github.com/apache/logging-log4cxx/commit/e64b7cf0fbdd2f799cd83a7361d4ceefb75eff84#diff-7f6195436d46cda43818b2013775e6feR117)
as well.
Please commit removing
[vstudio.apt](https://github.com/apache/logging-log4cxx/blob/master/src/site/apt/building/vstudio.apt)
as well.
##########
File path: pom.xml
##########
@@ -372,7 +372,6 @@
<reportSet>
<reports>
<report>scm</report>
-
<report>dependencies</report>
Review comment:
Why do you want to remove [that
page](https://logging.apache.org/log4cxx/next_stable/dependencies.html)? It
currently somewhat documents that `log4j` is necessary for the tests, doesn't
look too wrong to me. It would like to keep it for now.
##########
File path: src/site/xdoc/building/index.xml
##########
@@ -54,10 +54,10 @@
<thead>
<tr>
<th id="os">OS</th>
- <th id="os_x86_x64">x86 vs.
x64</th>
+ <th
id="os_x86_x64">Architecture</th>
Review comment:
Introducing a new header name is fine, but I suggest renaming those
`*_x86_x64` phrases to `*_arch` as well. Things are clearer this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
