ams-tschoening commented on a change in pull request #30:
URL: https://github.com/apache/logging-log4cxx/pull/30#discussion_r457926498



##########
File path: pom.xml
##########
@@ -372,7 +372,6 @@
                                        <reportSet>
                                                <reports>
                                                        <report>scm</report>
-                                                       
<report>dependencies</report>

Review comment:
       According to comments on the SO-question I created the following result 
as an example:
   
   
![Clipboard01](https://user-images.githubusercontent.com/6223655/88031086-64edbe00-cb3c-11ea-8f17-479c7d856053.png)
   
   The problem is to find the binaries, I didn't find something suitable for 
ZIP and GZIP yet. GREP is only used as an additional example because it was 
easily available. In theory we could create our own `pom.xml` describing the 
individual missing dependencies and maintain those with the project. OTOH this 
might not be easier instead of simply writing text like you have done already, 
but that should be a bit more prominent than. I like the scope-stuff already 
provided by Maven, though.
   
   Thoughts?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to