rm5248 commented on a change in pull request #49:
URL: https://github.com/apache/logging-log4cxx/pull/49#discussion_r554661934
##########
File path: src/CMakeLists.txt
##########
@@ -13,3 +13,19 @@ if(BUILD_TESTING)
add_subdirectory(test)
add_subdirectory(examples/cpp)
endif()
+
+option(BUILD_SITE "Build log4cxx website" OFF)
Review comment:
Some of the options are spread over different CMake files. This seemed
like the most logical place to put it at the time, but perhaps not. We could:
1. Put at top-level CMakeLists
2. Keep where it is
3. Create a new CMakeLists in src/site that contains this logic
Any of these options make sense to me, though perhaps option 3 makes the
most sense in terms of how the CMakeLists is currently structured(one
CMakeLists per directory).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
