[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #49: Documentation updates

[GitBox]

ams-tschoening commented on a change in pull request #49:
URL: https://github.com/apache/logging-log4cxx/pull/49#discussion_r555893325



##########
File path: CMakeLists.txt
##########
@@ -103,6 +105,25 @@ foreach(varName HAS_STD_LOCALE  HAS_ODBC  HAS_MBSRTOWCS  
HAS_WCSTOMBS  HAS_FWIDE
   endif()
 endforeach()
 
+#
+# Package and sign if Apache maintainer
+#
+option(APACHE_MAINTAINER "Apache maintainer" OFF)
+if(APACHE_MAINTAINER)
+set(CPACK_SOURCE_PACKAGE_FILE_NAME "apache-log4cxx-${LOG4CXX_RELEASE_VERSION}")
+set(CPACK_SOURCE_GENERATOR "TGZ;ZIP")
+set(CPACK_SOURCE_IGNORE_FILES ".git/;build/")
+include(CPack)
+
+add_custom_target( dist 

Review comment:
       thanks, found it with a little help:
   
   
https://devblogs.microsoft.com/cppblog/cmake-support-in-visual-studio-targets-view-single-file-compilation-and-cache-generation-settings/
   
   
![Clipboard01](https://user-images.githubusercontent.com/6223655/104340677-3c49ee00-54f9-11eb-819c-37108c4b6e09.png)
   
![Clipboard02](https://user-images.githubusercontent.com/6223655/104340680-3ce28480-54f9-11eb-9693-af9b9c523dc9.png)
   
![Clipboard03](https://user-images.githubusercontent.com/6223655/104340682-3d7b1b00-54f9-11eb-8a23-945f4a7eeec7.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org