[ 
https://issues.apache.org/jira/browse/LOGCXX-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456855#comment-17456855
 ] 

Truman Lackey commented on LOGCXX-537:
--------------------------------------

I will need to generate test code and configurations to reproduce this. I have 
created [https://github.com/bowb/logging-log4cxx/tree/mutex_fix] that appears 
to fix this.  [appenderskeleton 
change|http://example.comhttps//github.com/bowb/logging-log4cxx/blob/749378ba503a340ecdaef039275bd6f9e5c4108a/src/main/include/log4cxx/appenderskeleton.h#L77]
 It changes the mutex to a std::recursive_mutex and changes the locking to use 
std::lock_guard<std::recursive_mutex> lock(mutex);

> double mutex lock
> -----------------
>
>                 Key: LOGCXX-537
>                 URL: https://issues.apache.org/jira/browse/LOGCXX-537
>             Project: Log4cxx
>          Issue Type: Bug
>          Components: Appender
>    Affects Versions: 0.12.1
>         Environment: Ubuntu 18.04
>            Reporter: Truman Lackey
>            Priority: Major
>
> There is a possibility of the SocketAppender calling 
> std::unique_lock<log4cxx::shared_mutex> lock(mutex) twice causing a deadlock 
> exception. In socketappenderskeleton.cpp connect call if the exception is 
> caught on line 118 then fireConnector() will be called.  On line 160 the 
> mutex is attempted to be locked again but it has already been locked in the 
> appendersleketo.cpp doAppend call. This causes log4cxx to throw a  
> std::err::resource_deadlock_would_occur



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to