[ 
https://issues.apache.org/jira/browse/LOGCXX-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457631#comment-17457631
 ] 

Robert Middleton commented on LOGCXX-537:
-----------------------------------------

I will take a look at this shortly.

 

Part of the reason the mutex is not recursive in the first place is that I 
subscribe to the "recursive mutexes are bad" school of thought([some discussion 
here|https://stackoverflow.com/questions/187761/recursive-lock-mutex-vs-non-recursive-lock-mutex]).
  It should be pretty simple to fix though.

> double mutex lock
> -----------------
>
>                 Key: LOGCXX-537
>                 URL: https://issues.apache.org/jira/browse/LOGCXX-537
>             Project: Log4cxx
>          Issue Type: Bug
>          Components: Appender
>    Affects Versions: 0.12.1
>         Environment: Ubuntu 18.04
>            Reporter: Truman Lackey
>            Priority: Major
>             Fix For: 0.13.0
>
>
> There is a possibility of the SocketAppender calling 
> std::unique_lock<log4cxx::shared_mutex> lock(mutex) twice causing a deadlock 
> exception. In socketappenderskeleton.cpp connect call if the exception is 
> caught on line 118 then fireConnector() will be called.  On line 160 the 
> mutex is attempted to be locked again but it has already been locked in the 
> appendersleketo.cpp doAppend call. This causes log4cxx to throw a  
> std::err::resource_deadlock_would_occur



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to