ams-tschoening commented on a change in pull request #83:
URL: https://github.com/apache/logging-log4cxx/pull/83#discussion_r767901515
##########
File path: src/test/cpp/util/transformer.cpp
##########
@@ -116,14 +116,25 @@ void Transformer::createSedCommandFile(const std::string&
regexName,
std::string tmp;
+ auto sedsaniziter = [] (const std::string in, const std::string
sedseperator = "Q") {
Review comment:
Shouldn't the arguments better be `const std::string&`? Especially as
you are copying `in` again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
