ams-tschoening commented on a change in pull request #83:
URL: https://github.com/apache/logging-log4cxx/pull/83#discussion_r768790290
##########
File path: src/test/cpp/util/transformer.cpp
##########
@@ -116,14 +116,25 @@ void Transformer::createSedCommandFile(const std::string&
regexName,
std::string tmp;
+ auto sedsaniziter = [] (const std::string &in, const std::string
&sedseperator = "Q") {
+ std::string ret = in;
+ std::string replace_to = "\\" + sedseperator;
+ size_t pos = 0;
+ while((pos = ret.find(sedseperator, pos)) != std::string::npos)
{
Review comment:
Please add a newline before and after the `while`, make things better
readable.
##########
File path: src/test/cpp/util/transformer.cpp
##########
@@ -116,14 +116,25 @@ void Transformer::createSedCommandFile(const std::string&
regexName,
std::string tmp;
+ auto sedsaniziter = [] (const std::string &in, const std::string
&sedseperator = "Q") {
Review comment:
`sedsaniziter` contains a spelling error most likely, prefer
`sedSanitizer`. `sedseperator` should follow that naming with `sedSeperator` as
well. We mostly follow Java naming conventions.
Please change the references to be `const std::string& ...`, because most
other code does so already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
