rm5248 commented on a change in pull request #86:
URL: https://github.com/apache/logging-log4cxx/pull/86#discussion_r773494371
##########
File path: src/main/include/log4cxx/log4cxx.h.in
##########
@@ -29,10 +29,14 @@
#define LOG4CXX_VERSION_MINOR @log4cxx_VERSION_MINOR@
#define LOG4CXX_VERSION_PATCH @log4cxx_VERSION_PATCH@
#define LOG4CXX_VERSION_TWEAK @log4cxx_VERSION_TWEAK@
-#define LOG4CXX_MAKE_VERSION(major, minor, patch, tweak) ((major << 24) |\
- (minor << 16) |\
- (patch << 8) |\
+#define LOG4CXX_MAKE_VERSION(major, minor, patch, tweak) (((major) << 24) |\
+ ((minor) << 16) |\
+ ((patch) << 8) |\
Review comment:
the parentheses are not needed, since you should only pass in constants
to `LOG4CXX_MAKE_VERSION` in the first place: `LOG4CXX_MAKE_VERSION(0,0,12,0)`
for example. They don't hurt at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
