rm5248 commented on pull request #86:
URL: https://github.com/apache/logging-log4cxx/pull/86#issuecomment-1004401456
> The utility of LOG4CXX_VERSION_GET_{MAJOR,MINOR,PATCH,TWEAK} would be more
obvious if we were to add a version identifier object (i.e. an externally
visible integer value) to the DSO/DLL, which is something we should eventually
do, arguably in the next release, to assess library version compatibility at
run time. Such a version identifier would allow the client code to compare the
compile-time LOG4CXX_VERSION to the LOG4CXX_VERSION baked into the DSO/DLL in
use, and the LOG4CXX_VERSION_GET_{MAJOR,MINOR,PATCH,TWEAK} macros would allow
the code to report the (potentially conflicting) values in a human-readable
manner instead of the unreadable LOG4CXX_VERSION format.
That is what I was assuming the macros were for, but since there was no
corresponding addition to any of the code to return a version number it didn't
make much sense to me.
If you are able to add that easily, that would be helpful, otherwise I will
do it sometime in the coming days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
