swebb2066 edited a comment on pull request #87: URL: https://github.com/apache/logging-log4cxx/pull/87#issuecomment-999933135
Hi Robert, This should do the initial job just fine. However, a couple of things occur to me in hindsight. 1. Multi threaded logging to a single logger probably should be part of the unit tests rather than a throughput test. The mutex in log4cxx::Hierarchy (or AppenderAttachableImpl::appendLoopOnAppenders) effectively serialize the threads, so the results are not interesting. Also, in multi-thread applications, each thread is likely to use a different log4cxx::logger instance. I see the MultithreadTest unit test you added in March 2021 covers the single logger case. 2. It would be nice to be able to easily monitor changes in throughput in the future as changes (PRs) are proposed. I see in https://medium.com/nerd-for-tech/ci-build-performance-testing-with-github-action-e6b227097c83 there is already support available. Would you like me to spend some time looking at the options? How do you feel about introducing another dependency for CI benchmarking? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
