swebb2066 commented on pull request #87: URL: https://github.com/apache/logging-log4cxx/pull/87#issuecomment-1000882788
Your data shows the rate of disabled log calls for multithread case which should be near the single thread rate for each thread. On Dec 25, 2021 1:38 AM, Robert Middleton ***@***.***> wrote: I'll have to take a look at that; I would be surprised if that was a significant source of performance issues, but some testing would confirm that. FWIW, using the LOG4CXX_[level]_FMT family of macros and also the fact that we use a thread_local for the thread name<https://github.com/apache/logging-log4cxx/commit/aaaea6aadf3fda0d2e0511d7034305cf1e8b9353> should more than compensate for the extra time locking the weak_ptr. — Reply to this email directly, view it on GitHub<https://github.com/apache/logging-log4cxx/pull/87#issuecomment-1000862347>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADJDRC77R6BQ5WWZJFNMLXTUSSAT3ANCNFSM5KRSIELQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
