carterkozak opened a new pull request #697: URL: https://github.com/apache/logging-log4j2/pull/697
_This pr is meant only as an example for discussion_ What do you think about using a code formatter? In my experience, it makes reviews easier, avoids unnecessary style commits later on, and makes cherry-picking easier as style cannot diverge between branches that use the same formatter. The formatter would allow us to make use of automation tooling without worrying about ruining formatting across the codebase. Downside is that it doesn't allow for the formatter to be turned off for specific blocks of code, and doesn't support configuration. Existing changes are likely to merge conflict, however that can be resolved by running the formatter on the change, creating a new commit based on the diff, and applying that. The formatter requires some flags to work correctly on JDK17: https://github.com/diffplug/spotless/tree/main/plugin-maven#palantir-java-format -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
