garydgregory commented on pull request #697: URL: https://github.com/apache/logging-log4j2/pull/697#issuecomment-1012258440
The Eclipse formatter has so many options that it's dizzying. I'm sure we can bend it to our will ;-) Gary On Thu, Jan 13, 2022, 09:24 Carter Kozak ***@***.***> wrote: > I'm not suggesting merging anything that formats the entire codebase in > one go, this was meant as an example of the result before we commit to > going down that path. Rollout is another beast, it can be done by applying > constraints to files as they're modified rather than changing the world at > once. > > Committing to a particular formatter can be difficult because it > front-loads the style bikeshedding which it eliminates later on. It may not > be worthwhile, that's why I brought it up for discussion :-) > > A lot of folks use the eclipse formatter, I've never found a configuration > which works reasonably in all cases (lots of unnatural line breaks in > unexpected places, but it may be better now). > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/logging-log4j2/pull/697#issuecomment-1012183850>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAJB6N5QDVP5KW7Y2GJAD6TUV3ODTANCNFSM5L2VROLA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you commented.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
