garydgregory commented on a change in pull request #737:
URL: https://github.com/apache/logging-log4j2/pull/737#discussion_r799819579
##########
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/ConsoleAppenderBuilder.java
##########
@@ -107,6 +110,24 @@ public Appender parseAppender(final Element
appenderElement, final XmlConfigurat
}
break;
}
+ case FOLLOW_PARAM: {
+ String value = getValueAttribute(currentElement);
+ if (value == null) {
+ LOGGER.warn("No value supplied for Follow
parameter. Using default of {}", false);
+ } else {
+ follow.set(Boolean.valueOf(value));
+ }
+ break;
+ }
+ case IMMEDIATE_FLUSH_PARAM: {
+ String value = getValueAttribute(currentElement);
+ if (value == null) {
+ LOGGER.warn("No value supplied for
ImmediateFlush parameter. Using default of {}", true);
+ } else if (!Boolean.getBoolean(name)) {
+ LOGGER.warn("The value {} for ImmediateFlush
parameter is not supported.", false);
+ }
Review comment:
FYI : This seems incomplete, where is the value used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
