ppkarwasz commented on a change in pull request #737:
URL: https://github.com/apache/logging-log4j2/pull/737#discussion_r800038422
##########
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/ConsoleAppenderBuilder.java
##########
@@ -107,6 +110,24 @@ public Appender parseAppender(final Element
appenderElement, final XmlConfigurat
}
break;
}
+ case FOLLOW_PARAM: {
+ String value = getValueAttribute(currentElement);
+ if (value == null) {
+ LOGGER.warn("No value supplied for Follow
parameter. Using default of {}", false);
+ } else {
+ follow.set(Boolean.valueOf(value));
+ }
+ break;
+ }
+ case IMMEDIATE_FLUSH_PARAM: {
+ String value = getValueAttribute(currentElement);
+ if (value == null) {
+ LOGGER.warn("No value supplied for
ImmediateFlush parameter. Using default of {}", true);
+ } else if (!Boolean.getBoolean(name)) {
+ LOGGER.warn("The value {} for ImmediateFlush
parameter is not supported.", false);
+ }
Review comment:
Since the Log4j2 `ConsoleAppender` does not use the `immediateFlush`
parameter (cf.
[`ConsoleAppender.Builder#build`](https://github.com/apache/logging-log4j2/blob/0de646bde36d2c426988970314428d68b8858a5a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/ConsoleAppender.java#L218)),
I only issue a warning that the value supplied by the user will be ignored.
Alternatively the Log4j2 `ConsoleAppender` could issue a warning if
`immediateValue`, `bufferedIO` or `bufferSize` differ from the default values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
