garydgregory commented on a change in pull request #783:
URL: https://github.com/apache/logging-log4j2/pull/783#discussion_r819689059
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/Property.java
##########
@@ -118,15 +119,38 @@ public static Property createProperty(final String name,
final String value) {
* @param value The value.
* @return A Property.
*/
+ public static Property createProperty(
+ final String name,
+ final String rawValue,
+ final String value) {
+ if (name == null) {
+ LOGGER.error("Property name cannot be null");
Review comment:
If it's an error and we continue as if nothing happened, then either
this should not be logged as an ERROR or some error-like behavior should
happen. It's just weird to log an ERROR and then continue as if nothing
happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
