carterkozak commented on a change in pull request #783:
URL: https://github.com/apache/logging-log4j2/pull/783#discussion_r819703318
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/Property.java
##########
@@ -118,15 +119,38 @@ public static Property createProperty(final String name,
final String value) {
* @param value The value.
* @return A Property.
*/
+ public static Property createProperty(
+ final String name,
+ final String rawValue,
+ final String value) {
+ if (name == null) {
+ LOGGER.error("Property name cannot be null");
Review comment:
Agree that this is odd, it matches the behavior of the previous
plugin-based constructor. I have to imagine anything that receives a Property
instance with a null key will throw, so it's probably best to throw in this
case. I can update all the constructors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
