ppkarwasz commented on a change in pull request #788:
URL: https://github.com/apache/logging-log4j2/pull/788#discussion_r822975410
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java
##########
@@ -214,7 +214,7 @@ public Filter getFilter() {
return filter;
}
- public B withtFilter(Filter filter) {
+ public B withFilter(Filter filter) {
Review comment:
I have mixed feelings about this change: yes, it would be nice to have a
correctly spelled method, but the other one was already released and it is API.
Don't change the name of the method, deprecate it and add another one with
the correct spelling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
