phreed commented on a change in pull request #788:
URL: https://github.com/apache/logging-log4j2/pull/788#discussion_r823038591
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java
##########
@@ -214,7 +214,7 @@ public Filter getFilter() {
return filter;
}
- public B withtFilter(Filter filter) {
+ public B withFilter(Filter filter) {
Review comment:
There were two such cases.
What is the rule for naming methods?
When should the name be `setFilter` and when `withFilter`?
I just noticed that the appender was changed from `setFilter` and when
`withFilter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
