dfa1 commented on pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#issuecomment-1073049642
@rgoers @carterkozak @garydgregory
*Current state*
- this PR is implementing the SLF4J's contract is a reasonable way (my
humble opinion)
- test coverage is good
- it is possible to create directly detached markers
- it is possible to detach an existing `Marker` (my use case with
`StructuredArg`) to avoid any processing by log4j
- detached markers can be filtering by name (checked with @carterkozak
in `MarkerFilter`)
- `Marker.isInstanceOf(Marker)` is not working properly for detached
markers because of identify comparison (this could be a problem for people
using detached markers with log4j)
I will be more than happy to:
- finish this PR, adding anything you think is important
- add these changes in `log4j-slf4j18-impl` too
- provide feedback, testing and bug fixing after merging
- help you to maintain this code
I don't see the point in using my time to maintain my "private" workarounds,
I would be happy (and honored too) to use my time to collaborate with you on
log4j 2.x instead! :)
My 2 cents,
D.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
