dfa1 commented on a change in pull request #770:
URL: https://github.com/apache/logging-log4j2/pull/770#discussion_r830646927
##########
File path:
log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/Log4jMarkerFactory.java
##########
@@ -36,9 +38,11 @@
private static final Logger LOGGER = StatusLogger.getLogger();
private final ConcurrentMap<String, Marker> markerMap = new
ConcurrentHashMap<>();
+ private final Set<String> detachedMarkers = new CopyOnWriteArraySet<>();
Review comment:
@ppkarwasz thank you for the review :) maybe the name of the field is
misleading: should be "detachedMarkerNames"? Anyway, for my use case, the
marker name is always "STRUCTURED_ARG" but every instance has different data
(i.e. health check data).
Basically, log4j is designed to use markers as "glorified strings", instead
I would like to use them as "data carrier" (see my my discussion with @rgoers
below). I hope it is clear enough!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
