[ 
https://issues.apache.org/jira/browse/LOG4J2-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17533919#comment-17533919
 ] 

Ralph Goers commented on LOG4J2-3497:
-------------------------------------

{code:java}
Can't we simply make PluginManager honor ConstraintValidator annotations out of 
the box? {code}
As I said previously, PluginManager doesn't have anything to do with 
instantiating plugins. Doing what you are asking would require moving 
PluginBuilder into PluginManager. What is the point of that? What you should be 
asking is, "Can't we make all plugin creation use PluginBuilder?". I believe 
Matt has indicated why that can't be done.

Matt stated
{code:java}
I wish PluginManager would simply not exist and that functionality would be a 
part of the PluginRegistry {code}
As I recall, didn't you create both of those classes? You could certainly move 
all the PluginManager code to PluginRegistry but that could possibly impact 
users.

> ConstraintValidator's are not employed by PluginManager
> -------------------------------------------------------
>
>                 Key: LOG4J2-3497
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-3497
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Volkan Yazici
>            Assignee: Matt Sicker
>            Priority: Major
>             Fix For: 2.18.0
>
>
> {{ConstraintValidator}}'s are not taken into account when plugins are 
> collected via {{PluginManager}}.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to