mneundorfer commented on code in PR #836:
URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r868963040
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java:
##########
@@ -610,8 +610,8 @@ public static Rfc5424Layout createLayout(
// @formatter:off
@PluginAttribute(value = "facility", defaultString = "LOCAL0")
final Facility facility,
@PluginAttribute("id") final String id,
- @PluginAttribute(value = "enterpriseNumber", defaultInt =
DEFAULT_ENTERPRISE_NUMBER)
- final int enterpriseNumber,
+ @PluginAttribute(value = "enterpriseNumber", defaultString =
DEFAULT_ENTERPRISE_NUMBER)
+ final String enterpriseNumber,
Review Comment:
Deprecating this constructor and introducing a Builder feels like it could
be a separate MR? In case I still should give it a shot, what do you mean by
"validate" the parameter? What kind o f validation would you expect there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
