ppkarwasz commented on code in PR #836:
URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r871104793
##########
log4j-api/src/main/java/org/apache/logging/log4j/message/StructuredDataId.java:
##########
@@ -139,11 +139,30 @@ public StructuredDataId(final String name, final String
enterpriseNumber, final
* @param enterpriseNumber The enterprise number.
* @param required The list of keys that are required for this id.
* @param optional The list of keys that are optional for this id.
+ * @deprecated Use {@link #StructuredDataId(String, String, String[],
String[])} instead.
+ */
+ @Deprecated
+ public StructuredDataId(final String name, final int enterpriseNumber,
final String[] required,
+ final String[] optional) {
+ this(name, String.valueOf(enterpriseNumber), required, optional,
MAX_LENGTH);
+ }
+
+ /**
+ * A Constructor that helps conformance to RFC 5424.
+ *
+ * Deprecated:
+ * enterpriseNumber should be a String, use StructuredDataId(final String
name, final String enterpriseNumber, final String[] required,
+ * final String[] optional, final int maxLength)
Review Comment:
The "deprecated" comment shouldn't be in the Javadoc of the other
constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
