rgoers commented on code in PR #836:
URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r871587464
##########
log4j-core/src/test/java/org/apache/logging/log4j/core/appender/TlsSyslogAppenderTest.java:
##########
@@ -94,7 +94,7 @@ private SyslogAppender createAppender() {
}
return SyslogAppender.createAppender("localhost", PORTNUM, "SSL",
sslConfiguration, 0, -1, true, "Test", true,
- false, Facility.LOCAL0, "Audit", 18060, true, "RequestContext",
null, null, includeNewLine, null,
+ false, Facility.LOCAL0, "Audit", "18060", true, "RequestContext",
null, null, includeNewLine, null,
Review Comment:
You mean - existing tests should not be modified. New ones should be created
to test the new functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
