[
https://issues.apache.org/jira/browse/LOG4J2-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617825#comment-17617825
]
Phillip Webb commented on LOG4J2-3618:
--------------------------------------
Thanks [~pkarwasz]. We do have a different priority from the standard property
sources so I think most production apps won't encounter the issue. I found the
problem when writing some tests and found that a property source from an
earlier tests wasn't replaced by one in a later test.
> Multiple PropertySources with identical priority cannot be added to
> PropertiesUtil Environment
> ----------------------------------------------------------------------------------------------
>
> Key: LOG4J2-3618
> URL: https://issues.apache.org/jira/browse/LOG4J2-3618
> Project: Log4j 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.17.2
> Reporter: Phillip Webb
> Priority: Minor
>
> The {{org.apache.logging.log4j.util.PropertiesUtil.Environment}} maintains a
> set of {{sources}} by using a {{ConcurrentSkipListSet}} backed with a
> {{PropertySource.Comparator}}.
> Somewhat surprisingly, the {{ConcurrentSkipListSet}} will not add an item if
> comparing it to an existing one returns {{0}}. This means that all
> {{PropertySource}} implementations must have unique {{getPriority()}}
> results. I think this might be better to use a {{Set}} that uses
> {{equals/hashCode}} to determine if items can be added and only use the
> {{Comparator}} for sorting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
