rgoers commented on code in PR #1164:
URL: https://github.com/apache/logging-log4j2/pull/1164#discussion_r1047167520
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationSource.java:
##########
@@ -367,7 +357,7 @@ private static ConfigurationSource
getConfigurationSource(URL url) {
try {
if (file != null) {
return new
ConfigurationSource(urlConnection.getInputStream(),
FileUtils.fileFromUri(url.toURI()));
- } else if (JAR.equals(url.getProtocol())) {
+ } else if (urlConnection instanceof JarURLConnection) {
Review Comment:
@ppkarwasz Yes, that sounds like a better solution. This merge should be
reverted. Also, if the call to getLastModified is leaking file descriptors
shouldn't an issue be raised with the JDK as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
