ppkarwasz commented on code in PR #1164:
URL: https://github.com/apache/logging-log4j2/pull/1164#discussion_r1047194010
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationSource.java:
##########
@@ -367,7 +357,7 @@ private static ConfigurationSource
getConfigurationSource(URL url) {
try {
if (file != null) {
return new
ConfigurationSource(urlConnection.getInputStream(),
FileUtils.fileFromUri(url.toURI()));
- } else if (JAR.equals(url.getProtocol())) {
+ } else if (urlConnection instanceof JarURLConnection) {
Review Comment:
@rgoers: my point is that `urlConnection instanceof JarURLConnection` is
probably the right thing to do here.
As for the JDK bug:
[JDK-6956385](https://bugs.openjdk.java.net/browse/JDK-6956385) has been
reported so many years ago, that it should probably be considered a feature by
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
