ppkarwasz commented on PR #1173: URL: https://github.com/apache/logging-log4j2/pull/1173#issuecomment-1369196283
> I have a nagging wish to convert `PatternProcessorTest` to use `java.time` and use date formats `ISO_ZONED_DATE_TIME`, `ISO_INSTANT`. Would that be useful? (this would reduce some verbosity; it could be done as separate "migration" commit) You can do whatever you want in test classes. In the main classes like `PatternProcessor` however, we strive to achieve a garbage-free code, so AFAIK we are stuck with `Calendar`. @rgoers, is it safe to assume that calls to `PatternProcessor#getNextTime` are synchronized and we can replaced the two `Calendar.getInstance()` calls with cached instances? It certainly seems so in the current code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
