ppkarwasz commented on code in PR #1173:
URL: https://github.com/apache/logging-log4j2/pull/1173#discussion_r1060198001
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/rolling/PatternProcessorTest.java:
##########
@@ -274,4 +310,171 @@ public void
testGetNextTimeWeeklyReturnsFirstWeekInYear_US() {
Locale.setDefault(old);
}
}
+
+ @Test
+ @ResourceLock(value = Resources.LOCALE, mode = ResourceAccessMode.READ)
+ public void testGetNextTimeDailyReturnsFirstHourOfNextDay() {
+ final PatternProcessor pp = new
PatternProcessor("logs/app-%d{yyyy-MM-dd}.log.gz");
+ final Calendar initial = Calendar.getInstance();
+ initial.set(2014, Calendar.MARCH, 4, 2, 31, 59); // Tue, March 4,
2014, 02:31
+ final long actual = pp.getNextTime(initial.getTimeInMillis(), 1,
false);
+
+ // expect Wed, March 5, 2014, 00:00
+ final Calendar expected = Calendar.getInstance();
+ expected.set(2014, Calendar.MARCH, 5, 0, 0, 0);
+ expected.set(Calendar.MILLISECOND, 0);
+ assertEquals(format(expected.getTimeInMillis()), format(actual));
+ }
+
+ @Test
+ @ResourceLock(value = Resources.LOCALE, mode = ResourceAccessMode.READ)
+ public void
testGetNextTimeDailyReturnsFirstHourOfNextDayHonoringTimeZoneOption1() {
+ TimeZone.setDefault(TimeZone.getTimeZone("GMT-10")); // default is
ignored if pattern contains timezone
+ final PatternProcessor pp = new
PatternProcessor("logs/app-%d{yyyy-MM-dd}{GMT-6}.log.gz");
+ final Calendar initial =
Calendar.getInstance(TimeZone.getTimeZone("GMT-6"));
+ initial.set(2014, Calendar.MARCH, 4, 2, 31, 59); // Tue, March 4,
2014, 02:31
+ final long actual = pp.getNextTime(initial.getTimeInMillis(), 1,
false);
+
+ // expect Wed, March 5, 2014, 00:00
+ final Calendar expected =
Calendar.getInstance(TimeZone.getTimeZone("GMT-6"));
+ expected.set(2014, Calendar.MARCH, 5, 0, 0, 0);
+ expected.set(Calendar.MILLISECOND, 0);
+ assertEquals(format(expected.getTimeInMillis()), format(actual));
+ }
+
+ @Test
+ @ResourceLock(value = Resources.LOCALE, mode = ResourceAccessMode.READ)
+ @ResourceLock(value = Resources.TIME_ZONE, mode = ResourceAccessMode.READ)
Review Comment:
The access mode to `TIME_ZONE` should be `READ_WRITE` (the default if you
omit `mode`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
