swebb2066 commented on PR #216:
URL: https://github.com/apache/logging-log4cxx/pull/216#issuecomment-1595660940
To avoid clutering the base class by introducing a virutal destructor, we
could use the following change:
```
--- a/src/main/cpp/fixedwindowrollingpolicy.cpp
+++ b/src/main/cpp/fixedwindowrollingpolicy.cpp
@@ -57,7 +57,10 @@ FixedWindowRollingPolicy::FixedWindowRollingPolicy() :
{
}
-FixedWindowRollingPolicy::~FixedWindowRollingPolicy(){}
+FixedWindowRollingPolicy::~FixedWindowRollingPolicy()
+{
+ delete static_cast<FixedWindowRollingPolicyPrivate*>(m_priv.release());
+}
```
To address `new-delete-type-mismatch` completely the following files would
also need to be changed:
```
andfilter.cpp
aprdatagramsocket.cpp
aprserversocket.cpp
aprsocket.cpp
asyncappender.cpp
colorstartpatternconverter.cpp
consoleappender.cpp
datepatternconverter.cpp
dbappender.cpp
fileappender.cpp
filerenameaction.cpp
fixedwindowrollingpolicy.cpp
gzcompressaction.cpp
levelmatchfilter.cpp
levelrangefilter.cpp
literalpatternconverter.cpp
locationinfofilter.cpp
loggermatchfilter.cpp
mapfilter.cpp
multiprocessrollingfileappender.cpp
namepatternconverter.cpp
nteventlogappender.cpp
odbcappender.cpp
propertiespatternconverter.cpp
rollingfileappender.cpp
smtpappender.cpp
socketappenderskeleton.cpp
stringmatchfilter.cpp
syslogappender.cpp
telnetappender.cpp
writerappender.cpp
xmlsocketappender.cpp
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
