rm5248 commented on PR #216: URL: https://github.com/apache/logging-log4cxx/pull/216#issuecomment-1595744717
> I think the warning reported by AddressSanitizer (new-delete-type-mismatch) does not generally cause a problem - The full size memory block will be free()ed and returned to the heap. I'm not sure if it actually is - I had fixed a few ASAN errors a while ago by adding [virtual destructors to the base class](https://github.com/apache/logging-log4cxx/commit/a46055a65b29e828d5bf85c2595031f78672b429), because it was leaking memory(a string was being allocated in the parent class, but the parent destructor was never called so the string was never deleted). Adding the virtual destructor is a simple one-line fix instead of modifying ~20 files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
