jvz commented on code in PR #1863:
URL: https://github.com/apache/logging-log4j2/pull/1863#discussion_r1361012895
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java:
##########
@@ -711,7 +707,8 @@ public Configuration setConfiguration(final Configuration
config) {
prev.stop();
}
- firePropertyChangeEvent(new PropertyChangeEvent(this,
PROPERTY_CONFIG, prev, config));
+ final var event = new ConfigurationChangeEvent(this, prev, config);
+ configurationChangeListeners.forEach(listener ->
listener.onChange(event));
Review Comment:
I suppose that makes sense as an improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
