jvz commented on PR #1863: URL: https://github.com/apache/logging-log4j2/pull/1863#issuecomment-1764932276
> Looks good to me. > > If we are introducing a breaking change in `LoggerContext`, I would also reevaluate the role of [`ConfigurationListener`](https://github.com/apache/logging-log4j2/blob/main/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationListener.java). I have the impression that the two kinds of listeners have a very similar role and can be merged (of `ConfigurationListener` can be dropped). > > The role of `ConfigurationListener` is just to inform `LoggerContext` that the configuration file changed and trigger a reconfiguration. I don't think any other component really uses this interface: most components should wait for a `ConfigurationChangedEvent`. I agree that these two should probably be combined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
