vy commented on code in PR #1970:
URL: https://github.com/apache/logging-log4j2/pull/1970#discussion_r1395752043
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/util/BasicAuthorizationProvider.java:
##########
@@ -35,6 +38,11 @@ public class BasicAuthorizationProvider implements
AuthorizationProvider {
public static final String CONFIG_USER_NAME =
"log4j2.configurationUserName";
public static final String CONFIG_PASSWORD =
"log4j2.configurationPassword";
public static final String PASSWORD_DECRYPTOR = "log4j2.passwordDecryptor";
+ /*
+ * Properties used to specify the encoding in HTTP Basic Authentication
+ */
+ private static final String BASIC_AUTH_ENCODING =
"log4j2.configurationAuthorizationEncoding";
+ private static final String SPRING_BASIC_AUTH_ENCODING =
"logging.auth.encoding";
Review Comment:
I am not happy with
1. having `configuration` in a property name (isn't everything has something
to do with some _configuration_?)
2. adding Spring-specific functionality to a Spring-agnostic product
But... The rest of the class has already embraced these wrong conventions.
Hence, you successfully have mirrored it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
