ppkarwasz commented on code in PR #1970:
URL: https://github.com/apache/logging-log4j2/pull/1970#discussion_r1395778245
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/util/BasicAuthorizationProvider.java:
##########
@@ -35,6 +38,11 @@ public class BasicAuthorizationProvider implements
AuthorizationProvider {
public static final String CONFIG_USER_NAME =
"log4j2.configurationUserName";
public static final String CONFIG_PASSWORD =
"log4j2.configurationPassword";
public static final String PASSWORD_DECRYPTOR = "log4j2.passwordDecryptor";
+ /*
+ * Properties used to specify the encoding in HTTP Basic Authentication
+ */
+ private static final String BASIC_AUTH_ENCODING =
"log4j2.configurationAuthorizationEncoding";
+ private static final String SPRING_BASIC_AUTH_ENCODING =
"logging.auth.encoding";
Review Comment:
I think these property are transitional, because:
- most password are ASCII anyway, since you need sometimes to type them on a
keyboard of an OS without advanced input methods,
- most modern OSes use `UTF-8` as system encoding anyway (Windows is the
exception),
- using system encodings is obsolete (besides the system encoding of the
client and server might differ).
I will **drop** these configuration properties in `3.x` and leave `UTF-8` as
only encoding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
